Re: [Orekit Developers] OEMWriter Work

[Luc Maisonobe <Luc.Maisonobe@c-s.fr>]

Le 04/01/2017 à 16:56, Hank Grabowski a écrit :
> I've applied these suggestions to the 259-OrekitEphemerisPropagator
> branch, ready for review...

Fine, thanks.

I have added a few modifications to ensure files use standardized
formats. The original tests failed on my computer which is
configured to use French locale, and hence uses comma instead
of dot as decimal separator. Now even on a French computer, the
dot is properly used and the generated files can cross borders!

Everything as been pushed on the master branch.

You can marke issue 259 as solved.

best regards,
Luc

> 
> On Tue, Jan 3, 2017 at 10:45 AM, Hank Grabowski <hank@applieddefense.com
> <mailto:hank@applieddefense.com>> wrote:
> 
>     Those sound reasonable.  I've never used the OrekitMessages stuff
>     before so I may have questions when I make the changes, but I'll let
>     you know.  
> 
>     On Mon, Jan 2, 2017 at 11:13 AM, MAISONOBE Luc <luc.maisonobe@c-s.fr
>     <mailto:luc.maisonobe@c-s.fr>> wrote:
> 
> 
>         Hi Hank,
> 
>         MAISONOBE Luc <luc.maisonobe@c-s.fr
>         <mailto:luc.maisonobe@c-s.fr>> a écrit :
> 
>             Hank Grabowski <hank@applieddefense.com
>             <mailto:hank@applieddefense.com>> a écrit :
> 
>                 I've finished the implementation of the OEMWriter, and
>                 the corresponding
>                 unit tests.  They are ready for review on branch
>                 259-OEMWriter.  I also
>                 created an OrekitEphemerisFile object for easier
>                 serialization to an
>                 external ephemeris format, with corresponding unit test
>                 for showing to/from
>                 OEM file.  That is in a separate branch
>                 called 259-OrekitEphemerisPropagator off of the original
>                 259-OEMWriter
>                 branch.  Both should be ready for review.
> 
> 
>             Thanks Hank,
> 
>             I'll try to review this next week.
> 
> 
>         I have reviewed your changes. They seem fine to me, there are
>         just a few
>         details that could be improved.
> 
>          - rather than throwing IllegalArgumentException with English
>         fixed formats,
>            we should rather use OrekitIllegalArgumentException and dedicated
>            entries in the OrekitMessages enum for the format. Beware the
>         resource
>            files in src/main/resources/assets/org/orekit/localization
>         must include
>            the entries, or OrekitMessagesTest junit tests will fail. If
>         you look
>            in these files, you will see how to setup the entries for
>         languages
>            you don't know about (search for <MISSING TRANSLATION>),
> 
>          - the branch is a few commits late with respect to master, I
>         did not try
>            to merge myself, so do not know if there are any conflicts,
> 
>          - the src/site/xdoc/changes.xml, src/site/markdown/index.md
>         <http://index.md> and
>            src/main/java/overview.html should be updated to notify users
>         about the
>            new feature (note the two last files have similar content but
>         with
>            different syntax, html vs. markdown).
> 
>         Thanks a lot for this new feature!
> 
>         best regards,
>         Luc
> 
> 
>             best regards,
>             Luc
> 
> 
>                 Hank
> 
> 
> 
> 
>