SpotBugs Bug Detector Report

The following document contains the results of SpotBugs

SpotBugs Version is 3.1.7

Threshold is

Effort is default

Summary

Classes Bugs Errors Missing Classes
1313 43 0 0

Files

Class Bugs
org.orekit.attitudes.AttitudesSequence 1
org.orekit.estimation.measurements.PV 2
org.orekit.estimation.measurements.Position 2
org.orekit.estimation.measurements.modifiers.DynamicOutlierFilter 2
org.orekit.estimation.measurements.modifiers.RangeRateTroposphericDelayModifier 1
org.orekit.estimation.measurements.modifiers.RangeTroposphericDelayModifier 1
org.orekit.estimation.measurements.modifiers.TurnAroundRangeTroposphericDelayModifier 2
org.orekit.estimation.sequential.UnivariateProcessNoise 5
org.orekit.gnss.RinexLoader$Parser$PhaseShiftCorrection 1
org.orekit.gnss.attitude.GPSBlockIIA 2
org.orekit.gnss.attitude.GPSBlockIIF 1
org.orekit.gnss.attitude.GPSBlockIIR 1
org.orekit.gnss.attitude.Galileo 1
org.orekit.models.earth.EstimatedTroposphericModel 1
org.orekit.models.earth.NiellMappingFunctionModel 9
org.orekit.models.earth.ViennaOneModel 1
org.orekit.models.earth.ViennaThreeModel 1
org.orekit.propagation.analytical.tle.TLE 1
org.orekit.propagation.analytical.tle.TLESeries$TLEComparator 1
org.orekit.propagation.events.FunctionalDetector 2
org.orekit.propagation.events.InterSatDirectViewDetector 1
org.orekit.propagation.events.PositionAngleDetector 2
org.orekit.time.GPSDate 1
org.orekit.utils.IERSConventions 1

org.orekit.attitudes.AttitudesSequence

Bug Category Details Line Priority
Class org.orekit.attitudes.AttitudesSequence defines non-transient non-serializable instance field activated BAD_PRACTICE SE_BAD_FIELD Not available Medium

org.orekit.estimation.measurements.PV

Bug Category Details Line Priority
org.orekit.estimation.measurements.PV.getCovarianceMatrix() may expose internal representation by returning PV.covarianceMatrix MALICIOUS_CODE EI_EXPOSE_REP 420 Medium
new org.orekit.estimation.measurements.PV(AbsoluteDate, Vector3D, Vector3D, double[][], double, ObservableSatellite) may expose internal representation by storing an externally mutable object into PV.covarianceMatrix MALICIOUS_CODE EI_EXPOSE_REP2 397 Medium

org.orekit.estimation.measurements.Position

Bug Category Details Line Priority
org.orekit.estimation.measurements.Position.getCovarianceMatrix() may expose internal representation by returning Position.covarianceMatrix MALICIOUS_CODE EI_EXPOSE_REP 241 Medium
new org.orekit.estimation.measurements.Position(AbsoluteDate, Vector3D, double[][], double, ObservableSatellite) may expose internal representation by storing an externally mutable object into Position.covarianceMatrix MALICIOUS_CODE EI_EXPOSE_REP2 226 Medium

org.orekit.estimation.measurements.modifiers.DynamicOutlierFilter

Bug Category Details Line Priority
org.orekit.estimation.measurements.modifiers.DynamicOutlierFilter.getSigma() may expose internal representation by returning DynamicOutlierFilter.sigma MALICIOUS_CODE EI_EXPOSE_REP 54 Medium
org.orekit.estimation.measurements.modifiers.DynamicOutlierFilter.setSigma(double[]) may expose internal representation by storing an externally mutable object into DynamicOutlierFilter.sigma MALICIOUS_CODE EI_EXPOSE_REP2 61 Medium

org.orekit.estimation.measurements.modifiers.RangeRateTroposphericDelayModifier

Bug Category Details Line Priority
Dead store to djac in org.orekit.estimation.measurements.modifiers.RangeRateTroposphericDelayModifier.modify(EstimatedMeasurement) STYLE DLS_DEAD_LOCAL_STORE 310 Medium

org.orekit.estimation.measurements.modifiers.RangeTroposphericDelayModifier

Bug Category Details Line Priority
Dead store to djac in org.orekit.estimation.measurements.modifiers.RangeTroposphericDelayModifier.modify(EstimatedMeasurement) STYLE DLS_DEAD_LOCAL_STORE 262 Medium

org.orekit.estimation.measurements.modifiers.TurnAroundRangeTroposphericDelayModifier

Bug Category Details Line Priority
Dead store to masterDjac in org.orekit.estimation.measurements.modifiers.TurnAroundRangeTroposphericDelayModifier.modify(EstimatedMeasurement) STYLE DLS_DEAD_LOCAL_STORE 263 Medium
Dead store to slaveDjac in org.orekit.estimation.measurements.modifiers.TurnAroundRangeTroposphericDelayModifier.modify(EstimatedMeasurement) STYLE DLS_DEAD_LOCAL_STORE 264 Medium

org.orekit.estimation.sequential.UnivariateProcessNoise

Bug Category Details Line Priority
org.orekit.estimation.sequential.UnivariateProcessNoise.getLofCartesianOrbitalParametersEvolution() may expose internal representation by returning UnivariateProcessNoise.lofCartesianOrbitalParametersEvolution MALICIOUS_CODE EI_EXPOSE_REP 124 Medium
org.orekit.estimation.sequential.UnivariateProcessNoise.getPropagationParametersEvolution() may expose internal representation by returning UnivariateProcessNoise.propagationParametersEvolution MALICIOUS_CODE EI_EXPOSE_REP 131 Medium
new org.orekit.estimation.sequential.UnivariateProcessNoise(RealMatrix, LOFType, PositionAngle, UnivariateFunction[], UnivariateFunction[]) may expose internal representation by storing an externally mutable object into UnivariateProcessNoise.lofCartesianOrbitalParametersEvolution MALICIOUS_CODE EI_EXPOSE_REP2 96 Medium
new org.orekit.estimation.sequential.UnivariateProcessNoise(RealMatrix, LOFType, PositionAngle, UnivariateFunction[], UnivariateFunction[]) may expose internal representation by storing an externally mutable object into UnivariateProcessNoise.propagationParametersEvolution MALICIOUS_CODE EI_EXPOSE_REP2 97 Medium
Useless object stored in variable MOM of method org.orekit.estimation.sequential.UnivariateProcessNoise.getInertialOrbitalProcessNoiseMatrix(SpacecraftState, SpacecraftState) STYLE UC_USELESS_OBJECT 201 Medium

org.orekit.gnss.RinexLoader$Parser$PhaseShiftCorrection

Bug Category Details Line Priority
org.orekit.gnss.RinexLoader$Parser$PhaseShiftCorrection.getSatsCorrected() may expose internal representation by returning RinexLoader$Parser$PhaseShiftCorrection.satsPhaseShift MALICIOUS_CODE EI_EXPOSE_REP 1175 Medium

org.orekit.gnss.attitude.GPSBlockIIA

Bug Category Details Line Priority
org.orekit.gnss.attitude.GPSBlockIIA.DEFAULT_YAW_RATES is a mutable array MALICIOUS_CODE MS_MUTABLE_ARRAY 53 Medium
Unread field: org.orekit.gnss.attitude.GPSBlockIIA.END_MARGIN; should this field be static? PERFORMANCE SS_SHOULD_BE_STATIC 66 Medium

org.orekit.gnss.attitude.GPSBlockIIF

Bug Category Details Line Priority
Unread field: org.orekit.gnss.attitude.GPSBlockIIF.END_MARGIN; should this field be static? PERFORMANCE SS_SHOULD_BE_STATIC 56 Medium

org.orekit.gnss.attitude.GPSBlockIIR

Bug Category Details Line Priority
Unread field: org.orekit.gnss.attitude.GPSBlockIIR.END_MARGIN; should this field be static? PERFORMANCE SS_SHOULD_BE_STATIC 50 Medium

org.orekit.gnss.attitude.Galileo

Bug Category Details Line Priority
Unread field: org.orekit.gnss.attitude.Galileo.END_MARGIN; should this field be static? PERFORMANCE SS_SHOULD_BE_STATIC 61 Medium

org.orekit.models.earth.EstimatedTroposphericModel

Bug Category Details Line Priority
Class org.orekit.models.earth.EstimatedTroposphericModel defines non-transient non-serializable instance field totalZenithDelay BAD_PRACTICE SE_BAD_FIELD Not available Medium

org.orekit.models.earth.NiellMappingFunctionModel

Bug Category Details Line Priority
The field org.orekit.models.earth.NiellMappingFunctionModel.ahAmplitudeFunction is transient but isn't set by deserialization BAD_PRACTICE SE_TRANSIENT_FIELD_NOT_RESTORED Not available Medium
The field org.orekit.models.earth.NiellMappingFunctionModel.ahAverageFunction is transient but isn't set by deserialization BAD_PRACTICE SE_TRANSIENT_FIELD_NOT_RESTORED Not available Medium
The field org.orekit.models.earth.NiellMappingFunctionModel.awFunction is transient but isn't set by deserialization BAD_PRACTICE SE_TRANSIENT_FIELD_NOT_RESTORED Not available Medium
The field org.orekit.models.earth.NiellMappingFunctionModel.bhAmplitudeFunction is transient but isn't set by deserialization BAD_PRACTICE SE_TRANSIENT_FIELD_NOT_RESTORED Not available Medium
The field org.orekit.models.earth.NiellMappingFunctionModel.bhAverageFunction is transient but isn't set by deserialization BAD_PRACTICE SE_TRANSIENT_FIELD_NOT_RESTORED Not available Medium
The field org.orekit.models.earth.NiellMappingFunctionModel.bwFunction is transient but isn't set by deserialization BAD_PRACTICE SE_TRANSIENT_FIELD_NOT_RESTORED Not available Medium
The field org.orekit.models.earth.NiellMappingFunctionModel.chAmplitudeFunction is transient but isn't set by deserialization BAD_PRACTICE SE_TRANSIENT_FIELD_NOT_RESTORED Not available Medium
The field org.orekit.models.earth.NiellMappingFunctionModel.chAverageFunction is transient but isn't set by deserialization BAD_PRACTICE SE_TRANSIENT_FIELD_NOT_RESTORED Not available Medium
The field org.orekit.models.earth.NiellMappingFunctionModel.cwFunction is transient but isn't set by deserialization BAD_PRACTICE SE_TRANSIENT_FIELD_NOT_RESTORED Not available Medium

org.orekit.models.earth.ViennaOneModel

Bug Category Details Line Priority
org.orekit.models.earth.ViennaOneModel.computeZenithDelay(double, double[], AbsoluteDate) may expose internal representation by returning ViennaOneModel.zenithDelay MALICIOUS_CODE EI_EXPOSE_REP 100 Medium

org.orekit.models.earth.ViennaThreeModel

Bug Category Details Line Priority
org.orekit.models.earth.ViennaThreeModel.computeZenithDelay(double, double[], AbsoluteDate) may expose internal representation by returning ViennaThreeModel.zenithDelay MALICIOUS_CODE EI_EXPOSE_REP 281 Medium

org.orekit.propagation.analytical.tle.TLE

Bug Category Details Line Priority
Test for floating point equality in org.orekit.propagation.analytical.tle.TLE.equals(Object) STYLE FE_FLOATING_POINT_EQUALITY 697 High

org.orekit.propagation.analytical.tle.TLESeries$TLEComparator

Bug Category Details Line Priority
org.orekit.propagation.analytical.tle.TLESeries$TLEComparator implements Comparator but not Serializable BAD_PRACTICE SE_COMPARATOR_SHOULD_BE_SERIALIZABLE 416-434 Medium

org.orekit.propagation.events.FunctionalDetector

Bug Category Details Line Priority
Class org.orekit.propagation.events.FunctionalDetector defines non-transient non-serializable instance field function BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.orekit.propagation.events.FunctionalDetector defines non-transient non-serializable instance field gFunction BAD_PRACTICE SE_BAD_FIELD Not available Medium

org.orekit.propagation.events.InterSatDirectViewDetector

Bug Category Details Line Priority
The field org.orekit.propagation.events.InterSatDirectViewDetector.slave is transient but isn't set by deserialization BAD_PRACTICE SE_TRANSIENT_FIELD_NOT_RESTORED Not available Medium

org.orekit.propagation.events.PositionAngleDetector

Bug Category Details Line Priority
Class org.orekit.propagation.events.PositionAngleDetector defines non-transient non-serializable instance field offsetEstimators BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.orekit.propagation.events.PositionAngleDetector defines non-transient non-serializable instance field positionAngleExtractor BAD_PRACTICE SE_BAD_FIELD Not available Medium

org.orekit.time.GPSDate

Bug Category Details Line Priority
The field org.orekit.time.GPSDate.date is transient but isn't set by deserialization BAD_PRACTICE SE_TRANSIENT_FIELD_NOT_RESTORED Not available Medium

org.orekit.utils.IERSConventions

Bug Category Details Line Priority
Redundant nullcheck of stream, which is known to be non-null in org.orekit.utils.IERSConventions.loadLoveNumbers(String) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 2621 Medium