[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Orekit Users] Building Orekit: commons-math dependency and TLEPropagator JUnit test

Christophe Garion <garion@isae.fr> a écrit :


Hi Christophe,

I have cloned the Orekit git repo and built Orekit using ant. The
BUILDING.txt file precises that you have to "customize" the properties
for the get-apache-commons-math target, but would it be easier to switch
directly to commons-math3 in the build.xml file:

  <property name="commons-math.version"    value="3.0" />
<property name="commons-math.jar" value="commons-math3-${commons-math.version}.jar" /> <property name="commons-math.maven.path" value="org/apache/commons/commons-math3" />

Moreover the BUILDING.txt file refers to commons-math 2.2 (see the
Eclipse part) and it seems that commons-math 3.0 is necessary to build

Ooops. Sorry, we forgot to update these files. This is now fixed in Git repository.

Finally, I have a JUnit failure for TLEPropagator:

Testcase: testBodyCenterInPointingDirection(org.orekit.propagation.analytical.tle.TLEPropagatorTest): FAILED
expected:<0.0> but was:<1.1959071802805094E-7>
junit.framework.AssertionFailedError: expected:<0.0> but was:<1.1959071802805094E-7> at org.orekit.propagation.analytical.tle.TLEPropagatorTest.testBodyCenterInPointingDirection(Unknown Source)

I have not investigated this error so far, sorry.

Thanks for the report, this is fixed now. In fact, the problem appeared because I updated the test after having fixed an issue in Apache Commons Math (see <https://issues.apache.org/jira/browse/MATH-801> and <http://svn.apache.org/viewvc?view=revision&revision=1346513>). A side effect of this fix was that the error in the Orekit test dropped from 1.2e-7 to 2.6e-8, so I updated the test. However, updating this test was an error because the Apache Commons Math fix will only be released with version 3.1 and Orekit currently depends on 3.0. So I have reverted the test threshold back to a larger value which is compatible with both versions of Apache Commons Math.

Thanks for the reports,

best regards,

Thanks for the good work by the way,


Christophe Garion          ISAE/DMIA - SUPAERO/IN
garion@isae.fr             10 avenue Edouard Belin
Tél : (33)5 61 33 80 57    BP 54032
Fax : (33)5 61 33 83 45    31055 Toulouse Cedex 4

This message was sent using IMP, the Internet Messaging Program.