[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [Orekit Users] DSST propagation



Hi Luc, 

Thanks for your support.
I will try to apply the suggested patch and let you know how it works. 

Best regards,
Mirco

___________________________________________________________

Mirco Rasotto
Software Engineer
Space
SCISYS Deutschland GmbH
T:  +49 6151 4285341 | F:  +49 6151 4285399  
E:  Mirco.Rasotto@scisys.de | http://www.space.scisys.de
 
SCISYS Deutschland GmbH, Darmstadt Office, Europaplatz 4, 64293 Darmstadt, Germany
Management Board: Prof. Dr.-Ing. Klaus-G. Meng (Chairman), Sandra Krewerth, Ulli Leibnitz, Dr. Karl-W. Pieper, Dr. Horst Wulf
Registered Office Bochum HRB 13694, VAT-Id-No. DE 813242674, WEEE-Reg.-No. DE 74530735

-----Original Message-----
From: orekit-users-request@orekit.org [mailto:orekit-users-request@orekit.org] On Behalf Of MAISONOBE Luc
Sent: 12 March 2018 16:44
To: orekit-users@orekit.org
Subject: Re: [Orekit Users] DSST propagation


Mirco Rasotto <Mirco.Rasotto@scisys.de> a écrit :

> Hi,

Hi Marco,

>
> I'm using the DSST semi-analytical propagator together with events.
> I noticed that the SpacecraftState s inside the handler function is 
> always the mean state, even if I set the boolean meanOnly to false in 
> the construction phase.
> Could you please confirm this, because I was not able to find any 
> information in the documentation.

I confirm the current behavior is to use the mean state, and I confirm it is a bug. We should use osculatinf state there.

Could you file a bug report on the forge at:  
<https://www.orekit.org/forge/projects/orekit/issues>?

Could you also tell us if applying the following patch solves the issue for you?
Beware it is not a definitive patch as it makes some non-regression tests fail very badly (with an exception), so it needs some additional work.

diff --git
a/src/main/java/org/orekit/propagation/integration/AbstractIntegratedPropagator.java
b/src/main/java/org/orekit/propagation/integration/AbstractIntegratedPropagator.java
index 4acab1615..f7be92a1d 100644
---
a/src/main/java/org/orekit/propagation/integration/AbstractIntegratedPropagator.java
+++  
b/src/main/java/org/orekit/propagation/integration/AbstractIntegratedPropagator.java
@@ -606,7 +606,7 @@ public abstract class AbstractIntegratedPropagator extends AbstractPropagator {
          throws OrekitException {

          // main state
-        SpacecraftState state = stateMapper.mapArrayToState(t, y,  
yDot, true);  //not sure of the mean orbit, should be true
+        SpacecraftState state = stateMapper.mapArrayToState(t, y,
yDot, meanOrbit);

          // pre-integrated additional states
          state = updateAdditionalStates(state);


best regards,
Luc



> Thanks.
>
> Regards,
> Mirco
>
> ___________________________________________________________
>
> Mirco Rasotto
> Software Engineer
> Space
> SCISYS Deutschland GmbH
> T:  +49 6151 4285341 | F:  +49 6151 4285399
> E:  Mirco.Rasotto@scisys.de<mailto:Mirco.Rasotto@scisys.de> | 
> http://www.space.scisys.de<http://www.space.scisys.de/>
>
> SCISYS Deutschland GmbH, Darmstadt Office, Europaplatz 4, 64293 
> Darmstadt, Germany Management Board: Prof. Dr.-Ing. Klaus-G. Meng 
> (Chairman), Sandra Krewerth, Ulli Leibnitz, Dr. Karl-W. Pieper, Dr. 
> Horst Wulf Registered Office Bochum HRB 13694, VAT-Id-No. DE 
> 813242674, WEEE-Reg.-No. DE 74530735