Re: [Orekit Developers] Re: new sp3 parser pacakge

[Luc Maisonobe <Luc.Maisonobe@c-s.fr>]

Le 20/12/2011 10:04, Luc Maisonobe a écrit :
> Le 19/12/2011 22:56, Thomas Neidhart a écrit :
>> On 12/19/2011 02:57 PM, MAISONOBE Luc wrote:
>>
>>> I don't think we have enabled the LineLength check for Orekit in out
>>> checkstyle configuration. Anyway I think with current IDE and screens,
>>> we can go to quite long lines if needed. We already use long
>>> identifiers, so it makes sense.
>>
>> I did have the wrong checkstyle configuration enabled ;-)
>> Committed all the updates wrt your review.
>>
>> The only thing missing is the update of the feature list.
> 
> Very good, thanks.
> I have merged the sp3 branch back into master (and deleted it).
> I have also added an entry in changes.xml for you.

Thomas, you can now change the status of the issue to resolve. We will
change it again to closed once the version is released.

Luc

> 
>>
>> btw. usually I like to add TODO comments for future improvements, but
>> there is a checkstyle rule for it. How do you handle this in orekit?
> 
> We don't handle it in the source code, but rather open an issue on the
> forge.
> 
> best regards,
> Luc
> 
>>
>> Best regards,
>>
>> Thomas
>>
>