[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [Orekit Developers] Data-related exceptions
Hi Guilhem,
>I feel that the current issue is that Orekit should use a more refined
>tree of exceptions or use native/standard exceptions, in order to
>distinguish different situations and allow each conceptual level to
>decide what to do with witch situation. But this needs lot of work (575
>occurrences of "throw new OrekitException").
I agree with your analysis. I also agree that it is a lot of work !
I noticed that all OrekitExceptions seem to use constants from OrekitMessages. So in a way, the exceptions are already organized in groups, based on the actual constant being used by the constructor. This reduces the number of different cases to refactor, from 575 (instantiations of OrekitExceptions) to around 170 (number of different messages). Still quite a lot, although using regular expressions, it would probably be possible to automate part of the work...
After a quick glance at all the different messages, it seems that if we focus only on the data-related exceptions, there would be a few dozen cases to handle. Still a significant endeavor, with potentially a lot of conflicts if other developments are on-going.
If we can find a design that is satisfactory for all developers, I am willing to help with the refactoring.
Regards,
Yannick
***************************************************************
Ce courriel (incluant ses eventuelles pieces jointes) peut contenir des informations confidentielles et/ou protegees ou dont la diffusion est restreinte. Si vous avez recu ce courriel par erreur, vous ne devez ni le copier, ni l'utiliser, ni en divulguer le contenu a quiconque. Merci d'en avertir immediatement l'expediteur et d'effacer ce courriel de votre systeme. Airbus Defence and Space et les sociétés Airbus Group declinent toute responsabilite en cas de corruption par virus, d'alteration ou de falsification de ce courriel lors de sa transmission par voie electronique.
This email (including any attachments) may contain confidential and/or privileged information or information otherwise protected from disclosure. If you are not the intended recipient, please notify the sender immediately, do not copy this message or any attachments and do not use it for any purpose or disclose its content to any person, but delete this message and any attachments from your system. Airbus Defence and Space and Airbus Group companies disclaim any and all liability if this email transmission was virus corrupted, altered or falsified.
---------------------------------------------------------------------
Airbus Defence and Space SAS (393 341 516 RCS Toulouse) - Capital: 29.821.072 EUR - Siege social: 31 rue des Cosmonautes, ZI du Palays, 31402 Toulouse cedex 4, France